Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(errorhandling): add common controller returning all errormessages #494

Conversation

ntruchsess
Copy link
Contributor

@ntruchsess ntruchsess commented Feb 8, 2024

Description

a new endpoint which returns all error-types, error-codes and error-messages that a service makes use of has been added.
The implementation of this endpoint is common for all services. It retrieves the data dynamically from the services IErrorMessageService-implementation.

corresponding CD-Repository PR: eclipse-tractusx/portal#176

Why

Currently no reliable documentation of error-types, error-codes and messages the services really make use of exists.

Issue

N/A

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes

@ntruchsess ntruchsess force-pushed the feature/CPLP-3454-endpoint-errorcodes branch 2 times, most recently from b083c02 to 4a17015 Compare February 8, 2024 17:04
@ntruchsess ntruchsess force-pushed the feature/CPLP-3454-endpoint-errorcodes branch 3 times, most recently from bff0c14 to 3d8031e Compare February 8, 2024 18:31
@ntruchsess ntruchsess marked this pull request as ready for review February 8, 2024 18:48
@ntruchsess ntruchsess requested a review from Phil91 February 8, 2024 18:48
@ntruchsess ntruchsess force-pushed the feature/CPLP-3454-endpoint-errorcodes branch 4 times, most recently from 419e411 to 12b614c Compare February 8, 2024 20:21
Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I just noticed, since we said we want to update all packages you might revert the changes of the existing Directory.Build.props and execute the update_framework_versions.sh script

@ntruchsess ntruchsess force-pushed the feature/CPLP-3454-endpoint-errorcodes branch from 12b614c to 9e39fdc Compare February 9, 2024 11:32
@ntruchsess ntruchsess requested a review from Phil91 February 9, 2024 11:32
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess
Copy link
Contributor Author

One thing I just noticed, since we said we want to update all packages you might revert the changes of the existing Directory.Build.props and execute the update_framework_versions.sh script

done

@Phil91 Phil91 merged commit 95a2b01 into eclipse-tractusx:release/v1.8.0-RC6 Feb 13, 2024
8 checks passed
@Phil91 Phil91 deleted the feature/CPLP-3454-endpoint-errorcodes branch February 13, 2024 07:02
Phil91 added a commit to eclipse-tractusx/portal that referenced this pull request Feb 14, 2024
Phil91 added a commit to eclipse-tractusx/portal that referenced this pull request Feb 14, 2024
Phil91 added a commit to eclipse-tractusx/portal that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants